Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle missing subscriber in subscription engine booting & pause #713

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

DavidBadura
Copy link
Member

  • skip booting subscription with missing subscriber
  • allow pause subscription with missing subscriber

@DavidBadura DavidBadura added the bug Something isn't working label Mar 20, 2025
@DavidBadura DavidBadura added this to the 3.10.4 milestone Mar 20, 2025
@DavidBadura DavidBadura changed the title handle missing subscriber in subscription engine booting & puase handle missing subscriber in subscription engine booting & pause Mar 20, 2025
@DanielBadura DanielBadura changed the base branch from 3.11.x to 3.10.x March 20, 2025 13:58
@DavidBadura DavidBadura merged commit 3b689b7 into 3.10.x Mar 20, 2025
39 of 40 checks passed
@DavidBadura DavidBadura deleted the fix-booting-handling branch March 20, 2025 13:59
Copy link

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.233s (±0.00%) | 3.253s (±0.00%) | -0.60%    | 46.816mb        | 47.348mb   | -1.12%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.002ms (±0.00%)   | 979.900μs (±0.00%) | +2.27%    | 34.199mb        | 34.199mb   | 0.00%       |
| benchLoad10000Events ()                | 51.834ms (±0.00%)  | 52.641ms (±0.00%)  | -1.53%    | 34.199mb        | 34.199mb   | 0.00%       |
| benchSave1Event ()                     | 896.500μs (±0.00%) | 893.200μs (±0.00%) | +0.37%    | 34.199mb        | 34.199mb   | 0.00%       |
| benchSave10000Events ()                | 227.597ms (±0.00%) | 233.153ms (±0.00%) | -2.38%    | 34.199mb        | 34.199mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.911s (±0.00%)    | 7.892s (±0.00%)    | +0.23%    | 34.199mb        | 34.199mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.970s (±0.00%)    | 4.985s (±0.00%)    | -0.30%    | 34.199mb        | 34.199mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.604ms (±0.00%)   | 4.745ms (±0.00%)   | -2.97%    | 37.575mb        | 37.575mb   | 0.00%       |
| benchSave10000Events () | 352.635ms (±0.00%) | 360.633ms (±0.00%) | -2.22%    | 37.577mb        | 37.577mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 51.906ms (±0.00%)  | 51.963ms (±0.00%)  | -0.11%    | 34.273mb        | 34.273mb   | 0.00%       |
| benchLoad10000Events ()                | 860.500μs (±0.00%) | 875.400μs (±0.00%) | -1.70%    | 34.273mb        | 34.273mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 986.400μs (±0.00%) | 982.900μs (±0.00%) | +0.36%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchLoad10000Events ()                | 56.342ms (±0.00%)  | 57.552ms (±0.00%)  | -2.10%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave1Event ()                     | 1.015ms (±0.00%)   | 996.800μs (±0.00%) | +1.80%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave10000Events ()                | 300.973ms (±0.00%) | 303.745ms (±0.00%) | -0.91%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.232s (±0.00%)    | 8.235s (±0.00%)    | -0.04%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.158s (±0.00%)    | 5.175s (±0.00%)    | -0.32%    | 34.382mb        | 34.382mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 900.800μs (±0.00%) | 932.500μs (±0.00%) | -3.40%    | 35.328mb        | 35.328mb   | 0.00%       |
| benchLoad10000Events ()                | 90.750ms (±0.00%)  | 90.625ms (±0.00%)  | +0.14%    | 35.329mb        | 35.329mb   | 0.00%       |
| benchSave1Event ()                     | 1.532ms (±0.00%)   | 1.605ms (±0.00%)   | -4.57%    | 35.328mb        | 35.328mb   | 0.00%       |
| benchSave10000Events ()                | 258.904ms (±0.00%) | 262.066ms (±0.00%) | -1.21%    | 35.331mb        | 35.331mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.207s (±0.00%)   | 12.375s (±0.00%)   | -1.36%    | 35.329mb        | 35.329mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.206s (±0.00%)    | 9.226s (±0.00%)    | -0.21%    | 35.830mb        | 35.830mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 76.300ms (±0.00%) | 75.363ms (±0.00%) | +1.24%    | 34.667mb        | 34.667mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants