Add ETH estimates #34
Conversation
src/api/ProjectsApi.js
Outdated
| this | ||
| ); | ||
| this.retrieveProjectsWithHttpInfo = | ||
| this.retrieveProjectsWithHttpInfo.bind(this); |
There was a problem hiding this comment.
It looks like there was a problem with my prettier settings yesterday and the code formatting hadn't run properly. Sorry about the noise here!
| expect(estimate.type).to.be.eq('ethereum'); | ||
| expect(estimate.mass_g).to.be.above(0); | ||
| expect(estimate.production).to.be.eq(false); | ||
| }); |
There was a problem hiding this comment.
Should there be tests for project_id,timestamp, and create_order params as well?
kleinjm
left a comment
kleinjm
left a comment
There was a problem hiding this comment.
No blockers but...
The test failures on this branch seem to be intermittently failing. I reran the GH actions and saw different errors on different node versions. I pulled this branch locally (toggling builds with nvm) and saw the same behavior where tests would fail randomly. Unfortunately, I couldn't reproduce stably nor do I see an obvious issue with the most common failure; createEthereumEstimate is undefined. I'm unsure if this is a common issue so didn't keep digging but let me know if you'd like to take a look together
Yeah, I think one of the issue is a race condition between the tests on each version of node. It looks like the preference test can have conflicts if several tests are run in a matrix. Let me add that to Asana. |
What
Why
SDK Release Checklist