Repository navigation
Demo site enhancements - #664
Merged
Merged
Conversation
…liance - Change distributed cache interval from 8 days to 25 hours - Update GetDistributedCacheAbsoluteExpiryTime to use buffer period semantics - This allows cross-server caching efficiency within MDS v3.1.1 rate limit window - Memory cache still expires at nextUpdateTime for rate limiting enforcement
Four things on the demo site were quietly not working: Tag helpers were only registered inside _Layout.cshtml, so pages got none. The one page-level use, <partial name="_options.cshtml" /> on the custom page, was emitted into the response as a literal <partial> element the browser ignored. The directive belongs in _ViewImports.cshtml, where every page picks it up. sweetalert2 was loaded unpinned -- which now serves v11 -- next to a stylesheet pinned at v6.10.1, and the calls still passed v8's removed "type" member instead of "icon". Every alert therefore rendered with mismatched styling and no icon. Pinned to 11.26.25 using the .all bundle, which carries its own CSS, and the stylesheet link dropped. detectFIDOSupport() looked for an element with id notSupportedWarning; no page had one, and nothing ever called the function. The "your browser does not support WebAuthn" banner could not appear. It now runs on DOMContentLoaded, and the banner is given the id in a following commit. The "read the source code for this demo" links pointed at /blob/main/Fido2Demo/..., which is neither the branch (master) nor the folder (Demo) -- every one of them 404'd. Also removed the popper.js tag: nothing on the site uses it, and Bulma does not need it.
The four scenarios each carried a full copy of the registration and authentication ceremonies -- eight
files, ~1250 lines, differing only in which options they set. Every bug in them existed four times over,
and each was real:
- After a failed fetch the catch showed an alert but did not return, so execution continued into
`makeCredentialOptions.status` on an undefined value and died with a TypeError that masked the original
error. Same shape after a failed navigator.credentials.create().
- Three of the four register files ended with `catch (e) { showErrorAlert(err.message ...) }` -- `err` is
not the bound variable, so the handler itself threw ReferenceError.
- registerNewCredential() is async but was called without await inside a try, so its catch could never
run.
- Pressing Escape at the browser prompt was reported as "the username is already registered with your
authenticator", which is misleading: a NotAllowedError/AbortError from a dismissed prompt is now
distinguished from a real failure and simply closes the dialog.
- The `mediation` argument was never passed to create() or get().
The ceremonies now live once in webauthn.js. Each page keeps a short file holding only the options that
make that scenario what it is -- which is what the "read the source code" links point readers at -- and
those links now name webauthn.js as well. The four scenario pages also gain the notSupportedWarning id
the previous commit's detectFIDOSupport() looks for, and the custom page's duplicated
Html.PartialAsync call is dropped so the options panel renders once rather than twice.
Net 1251 -> 669 lines, 124 of which are the vendored instant.js.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 78.64% 78.52% -0.13%
==========================================
Files 98 98
Lines 2548 2547 -1
Branches 425 424 -1
==========================================
- Hits 2004 2000 -4
- Misses 434 438 +4
+ Partials 110 109 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aseigler
force-pushed
the
demo-improvements
branch
from
September 11, 2026 23:37
41d9498 to
871d4f8
Compare
This was referenced Sep 21, 2026
This was referenced Sep 29, 2026
This was referenced Sep 30, 2026
This was referenced Oct 8, 2026
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.