Skip to content

Enable packing for Fido2.BlazorWebAssembly project - #601

Merged
abergs merged 1 commit into
passwordless-lib:mainfrom
Regenhardt:feature/wasm-package
Sep 1, 2025
Merged

abergs merged 1 commit into
passwordless-lib:mainfrom
Regenhardt:feature/wasm-package

Conversation

@Regenhardt

Copy link
Copy Markdown
Contributor

Turns out, release 4.0.0 didn't include the WebAssembly package. Whoops.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.04%. Comparing base (567965b) to head (8f4f99d).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files         101      101           
  Lines        2601     2601           
  Branches      432      432           
=======================================
  Hits         1978     1978           
  Misses        513      513           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Regenhardt

Copy link
Copy Markdown
Contributor Author

@abergs It would be nice to have this package as a 4.0.0 release also, is that possible?

@abergs

abergs commented Sep 1, 2025 •

Copy link
Copy Markdown
Collaborator

Hey @Regenhardt. I'm not a keen Blazor developer, I'm debating if I really want to take the responsibility of owning this package on or not.

I'm assuming this package will need updates as Blazor patterms evolve (It's relatively young as a framework) and I don't think I will be able to support that workload.

I think perhaps it's better if someone else owns and maintains that package?

@abergs

abergs commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

On second thought; the source of this package is Tiny and may not need to evolve that much over time. If you agree that there will likely not be a lot of changes, I'm ok with publishing it.

@Regenhardt

Copy link
Copy Markdown
Contributor Author

I expect there won't be too many more architectural changes to Blazor/JS-Interop now. I'll gladly keep this in mind if I notice any bigger changes in Blazor to check if it's still working. Also I expect a few people to actually use it so there's a good chance someone will notice and send a PR in case anything does indeed break it. Thanks for adding it, I'm glad will be under the same umbrella as the main packages.

@abergs
abergs merged commit 6fc9bc8 into passwordless-lib:main Sep 1, 2025
11 checks passed
@Regenhardt
Regenhardt deleted the feature/wasm-package branch September 1, 2025 19:02
@abergs

abergs commented Sep 2, 2025

Copy link
Copy Markdown
Collaborator

The packaged is published: https://www.nuget.org/packages/Fido2.BlazorWebAssembly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants