Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundantly stored credential ID #512

Closed
wants to merge 1 commit into from
Closed

Remove redundantly stored credential ID #512

wants to merge 1 commit into from

Conversation

Regenhardt
Copy link
Contributor

Part of #510

@abergs
Copy link
Collaborator

abergs commented Jul 15, 2024

I'm hesitant to merge this, I think it's wise to give people what they expect to see, as in an Id-field.
If anything I think we could remove the Descriptor from the StoredCredential to make it less alien?

@abergs
Copy link
Collaborator

abergs commented Jul 15, 2024

See #528 instead

@iamcarbon
Copy link
Contributor

Much prefer #528 (non-breaking) and also removes the redundancy! ❤️

@abergs abergs closed this Jul 16, 2024
@Regenhardt Regenhardt deleted the feature/remove-redundantly-stored-cred-id branch July 18, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Regenhardt @abergs @iamcarbon