Code

Improve Code Quality#421

Code

Merged

abergs merged 18 commits intopasswordless-lib:masterpasswordless-lib/fido2-net-lib:masterfrom carbon:cq15carbon/fido2-net-lib:cq15Copy head branch name to clipboardAug 17, 2023

+601-557

Commits

Commits on Aug 11, 2023

• Rename DeserializeAndValidateBlob -> DeserializeAndValidateBlobAsync

  iamcarbon

  committed
  76f3646

  Copy full SHA for 76f3646

• Make AuthenticatorAttestationResponse immutable

  iamcarbon

  committed
  f630b48

  Copy full SHA for f630b48

• Expose {PubArea,CertInfo}.Raw over a ReadOnlySpan<byte>

  iamcarbon

  committed
  87f561a

  Copy full SHA for 87f561a

• Make MDSGetEndpointResponse immutable

  iamcarbon

  committed
  287b62f

  Copy full SHA for 287b62f

• Make DevicePublicKeyAuthenticatorOutput immutable, and change properties that allocate to methods

  iamcarbon

  committed
  8a324f8

  Copy full SHA for 8a324f8

• Make AttestedCredentialData immutable

  iamcarbon

  committed
  12be4db

  Copy full SHA for 12be4db

• Add oid note

  iamcarbon

  committed
  a63e247

  Copy full SHA for a63e247

• Use Concat helper

  iamcarbon

  committed
  1b8c27f

  Copy full SHA for 1b8c27f

• Rename ecparams -> ecParams

  iamcarbon

  committed
  80bb866

  Copy full SHA for 80bb866

• Make AuthenticatorAssertionResponse immutable and improve nullability annotations

  iamcarbon

  committed
  134f3f8

  Copy full SHA for 134f3f8

• Make AuthenticatorAssertionResponse.Signature a ReadOnlySpan

  iamcarbon

  committed
  0a90650

  Copy full SHA for 0a90650

• Improve error message in AndroidKey

  iamcarbon

  committed
  57fb700

  Copy full SHA for 57fb700

• Use Concat helper

  iamcarbon

  committed
  52323ae

  Copy full SHA for 52323ae

• Breakout TrustAnchor logic from AuthenticatorAttestationResponse

  iamcarbon

  committed
  6f3b7fe

  Copy full SHA for 6f3b7fe

• Pass {config,metadataService, cancellationToken} to DevicePublicKeyRegistrationAsync

  iamcarbon

  committed
  3593612

  Copy full SHA for 3593612

• Move CryptoUtils -> /Extensions

  iamcarbon

  committed
  3f16810

  Copy full SHA for 3f16810

• Introduce VerifyAttestationRequest to remove state from AttestationVerifier

  iamcarbon

  committed
  d734a67

  Copy full SHA for d734a67

Commits on Aug 15, 2023

• Move CoseKeyTypeFromOid helper to COSE

  iamcarbon

  committed
  4299d94

  Copy full SHA for 4299d94