Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #417

Merged
merged 8 commits into from
Aug 11, 2023
Merged

Cleanup #417

merged 8 commits into from
Aug 11, 2023

Conversation

iamcarbon
Copy link
Contributor

  • Updates remaining files to use file-scoped namespaces
  • Removes unnecessary private setters
  • Fixes various typos
  • Cleans up tests a bit

There are no functional changes in this PR.

@iamcarbon
Copy link
Contributor Author

iamcarbon commented Aug 1, 2023

@abergs Ready for review. Mostly just a quick cleanup round of nits when reviewing the codebase.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #417 (31a11b5) into master (e6567d3) will decrease coverage by 0.22%.
The diff coverage is 81.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   75.02%   74.80%   -0.22%     
==========================================
  Files          95       95              
  Lines        2751     2751              
  Branches      457      457              
==========================================
- Hits         2064     2058       -6     
- Misses        575      580       +5     
- Partials      112      113       +1     
Files Changed Coverage Δ
Src/Fido2/AttestationFormat/AndroidKey.cs 95.23% <ø> (ø)
Src/Fido2/AuthenticatorAssertionResponse.cs 43.04% <ø> (ø)
Src/Fido2/AuthenticatorAttestationResponse.cs 76.37% <ø> (ø)
Src/Fido2/AuthenticatorResponse.cs 61.29% <0.00%> (ø)
Src/Fido2/CryptoUtils.cs 88.17% <ø> (ø)
Src/Fido2/Extensions/AuthDataHelper.cs 100.00% <ø> (ø)
Src/Fido2/Objects/CredentialPublicKey.cs 70.19% <ø> (ø)
Src/Fido2/AttestationFormat/Tpm.cs 94.62% <51.72%> (-5.02%) ⬇️
Src/Fido2/AttestationFormat/FidoU2f.cs 91.42% <91.42%> (ø)
Src/Fido2/Fido2NetLib.cs 91.66% <91.66%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

@abergs abergs self-requested a review August 2, 2023 08:54
@abergs
Copy link
Collaborator

abergs commented Aug 11, 2023

Nice, merging!

@abergs abergs merged commit bf75254 into passwordless-lib:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants