Fix demo project starting exception: change TargetFrameworks to TargetFramework - #403
Merged
Merged
Conversation
When performing `dotnet run` this change prevents a framework version specification error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 92 92
Lines 2714 2714
Branches 453 453
=======================================
Hits 2025 2025
Misses 575 575
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@dotnet-policy-service agree [company="{OwnID}"] |
Contributor
Author
|
@dotnet-policy-service agree company="OwnID" |
Contributor
Author
yedidyas
marked this pull request as draft
July 22, 2023 19:37
yedidyas
marked this pull request as ready for review
July 22, 2023 19:37
This was referenced Jan 18, 2026
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before my suggested change, on performing
dotnet runyou get a framework version specification error.This change makes the demo project a "clone&run" project, with zero extra effort.
The change is based on this response:
AvaloniaUI/Avalonia.Templates#25 (comment)