Make options de-/serializable by dotnet - #374
Regenhardt wants to merge 1 commit into
Conversation
|
Turns out PubKeyCredParams are immutable so giving the serializer a default constructor stops the deserialization form setting the properties. Guess I have to find out more about the |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 76.80% 76.82% +0.01%
==========================================
Files 89 89
Lines 2531 2533 +2
Branches 427 427
==========================================
+ Hits 1944 1946 +2
Misses 466 466
Partials 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
68cc943 to
1fbfb25
Compare
|
Ok this one works correctly now, telling the linker that if we keep the ctor we wanna keep the whole ctor. Will definitely open an issue with Microsoft to check if this is planned behaviour or if the linker needs a fix. |
|
Something like Fido2.Blazor or Fido2.WebAssembly or Fido2.BlazorWebAssembly like the sdk. |
|
Yes, moving things into a Blazor project (and small demo) would be ideal for changes like these. |
|
Since this became bigger as expected, I made a new branch: #379 |
closes #371