Simplify enum mapping & update specification links - #368
Merged
Merged
Conversation
Contributor
Author
abergs
approved these changes
Jan 25, 2023
abergs
left a comment
abergs
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Jason, this looks good!
Contributor
Author
|
@abergs Let me know if there's anything else here before we merge. |
Contributor
Author
|
@abergs Let me know if this is good to merge. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 74.70% 74.56% -0.14%
==========================================
Files 92 92
Lines 2728 2721 -7
Branches 456 454 -2
==========================================
- Hits 2038 2029 -9
- Misses 577 578 +1
- Partials 113 114 +1
|
This was referenced Jan 18, 2026
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Removes support for enforcing the case sensitivity of the Enum parser. Enum parsing has always been case insensitive in the library.
Update various references to a draft webauthn specification to the final published specification.