Skip to content

Fixes Fido2Configuration.FullyQualifiedOrigins contains a null entry when configured from a configuration section on .NET 7 - #360

Merged
abergs merged 1 commit into
masterfrom
unknown repository
Jan 11, 2023
Merged

abergs merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jan 1, 2023

Copy link
Copy Markdown

Fixes #359

…when configured from a configuration section on .NET 7
@codecov-commenter

codecov-commenter commented Jan 1, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.95%. Comparing base (e3851a7) to head (5e903e3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files          88       88           
  Lines        2513     2513           
  Branches      421      421           
=======================================
  Hits         1959     1959           
  Misses        439      439           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abergs abergs added the enhancement Enhancements or general improvements label Jan 11, 2023
@abergs

abergs commented Jan 11, 2023

Copy link
Copy Markdown
Collaborator

Thank you @ypoul, looks good!

@abergs
abergs self-requested a review January 11, 2023 16:01
@abergs

abergs commented Jan 11, 2023

Copy link
Copy Markdown
Collaborator

Note for the record: This is changing the public API, but not in a breaking way so can be included without major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements or general improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fido2Configuration.FullyQualifiedOrigins contains a null entry when configured from a configuration section on .NET 7

2 participants