Skip to content

Use file scoped namespaces - #343

Merged
abergs merged 1 commit into
passwordless-lib:masterfrom
carbon:cq1
Nov 24, 2022
Merged

abergs merged 1 commit into
passwordless-lib:masterfrom
carbon:cq1

Conversation

@iamcarbon

Copy link
Copy Markdown
Contributor

This PR converts the remaining files to use file-scoped namespaces. There are no functional changes in this PR.

@iamcarbon

Copy link
Copy Markdown
Contributor Author

@abergs @aseigler Ready for review / feedback.

@iamcarbon

Copy link
Copy Markdown
Contributor Author

@codecov-commenter

codecov-commenter commented Nov 24, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.69965% with 444 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.87%. Comparing base (dd727b1) to head (61a3590).

Files with missing lines Patch % Lines
Src/Fido2.Models/CredentialCreateOptions.cs 40.24% 47 Missing and 2 partials ⚠️
...c/Fido2/Metadata/Fido2MetadataServiceRepository.cs 60.39% 29 Missing and 11 partials ⚠️
Src/Fido2/Metadata/FileSystemMetadataRepository.cs 0.00% 34 Missing ⚠️
Src/Fido2.AspNet/Fido2NetLibBuilderExtensions.cs 0.00% 33 Missing ⚠️
Src/Fido2/ConformanceMetadataService.cs 0.00% 30 Missing ⚠️
Src/Fido2/AuthenticatorAssertionResponse.cs 49.12% 14 Missing and 15 partials ⚠️
Src/Fido2/Objects/CredentialPublicKey.cs 72.00% 20 Missing and 8 partials ⚠️
Src/Fido2/DevelopmentInMemoryStore.cs 0.00% 26 Missing ⚠️
Src/Fido2/Asn1Element.cs 67.79% 10 Missing and 9 partials ⚠️
...rc/Fido2.AspNet/DistributedCacheMetadataService.cs 84.21% 9 Missing and 6 partials ⚠️
... and 28 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files          88       88           
  Lines        2495     2495           
  Branches      415      415           
=======================================
  Hits         1943     1943           
  Misses        439      439           
  Partials      113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abergs
abergs merged commit 9823ec0 into passwordless-lib:master Nov 24, 2022
@abergs

abergs commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants