Skip to content

Add Mac and Linux to test pipeline - #332

Merged
aseigler merged 1 commit into
passwordless-lib:masterfrom
aseigler:feat-pipelines
Oct 14, 2022
Merged

aseigler merged 1 commit into
passwordless-lib:masterfrom
aseigler:feat-pipelines

Conversation

@aseigler

Copy link
Copy Markdown
Collaborator

Historically there have been several times where we've discovered code changes or test additions that work just fine on Windows, but are broken on Mac or Linux. This PR should help proactively fill that gap by:

  • Marking existing demo/test/coverage jobs to make it clear they are Windows specific
  • Adding job to test Mac and Linux
  • Updating tests where there are known/expected runtime issues

@aseigler aseigler added the feature New feature label Oct 12, 2022

@abergs abergs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES @aseigler!

@aseigler

Copy link
Copy Markdown
Collaborator Author

The Mac and Linux tests both have failing tests outstanding, but this should help bring some visibility.

@aseigler
aseigler merged commit 3e7161a into passwordless-lib:master Oct 14, 2022
@abergs

abergs commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

@aseigler Something weird on this one, we don't run the tests. Investigating...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants