Skip to content

Improve Code Quality - #326

Merged
abergs merged 3 commits into
passwordless-lib:masterfrom
carbon:testcoverage
Sep 28, 2022
Merged

abergs merged 3 commits into
passwordless-lib:masterfrom
carbon:testcoverage

Conversation

@iamcarbon

Copy link
Copy Markdown
Contributor
  • Remove TypedStringAbstraction & eliminate reflection use (was only used by AttestationType)
  • Update System.IdentityModel.Tokens.Jwt
  • Use more shared error messages and update assertions

@iamcarbon

Copy link
Copy Markdown
Contributor Author

@aseigler @abergs Ready for review.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #326 (0f6df43) into master (19c90bf) will increase coverage by 0.29%.
The diff coverage is 59.52%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   77.80%   78.09%   +0.29%     
==========================================
  Files          88       87       -1     
  Lines        2428     2433       +5     
  Branches      401      401              
==========================================
+ Hits         1889     1900      +11     
+ Misses        438      431       -7     
- Partials      101      102       +1     
Impacted Files Coverage Δ
Src/Fido2/Objects/AttestationType.cs 45.16% <43.33%> (-54.84%) ⬇️
Src/Fido2/AttestationFormat/AndroidKey.cs 95.29% <100.00%> (ø)
Src/Fido2/AttestationFormat/Apple.cs 93.54% <100.00%> (ø)
Src/Fido2/AttestationFormat/Packed.cs 98.14% <100.00%> (ø)
Src/Fido2/AttestationFormat/Tpm.cs 99.64% <100.00%> (ø)
Src/Fido2/Fido2ErrorMessages.cs 100.00% <100.00%> (ø)
...rc/Fido2/Serialization/AttestationTypeConverter.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abergs abergs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamcarbon Can you elaborate on the benefits of remving typedString?

@abergs

abergs commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

@iamcarbon Good work. Will rebase & merge but would love to hear the reasoning of typedstring removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants