Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix Release CI #92

Merged
merged 1 commit into from
Oct 28, 2024
Merged

ci: fix Release CI #92

merged 1 commit into from
Oct 28, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Oct 24, 2024

What's New?

Bug:

Fix:

  • Set the used PR workflow to inherit secrets
  • Set the PR workflow as a dependency of the release job

Screenshots (if appropriate):

Please attach any screenshots that would help illustrate the changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Add any other context or screenshots about the pull request here.

Copy link

@ctran88 ctran88 marked this pull request as ready for review October 24, 2024 17:46
@ctran88 ctran88 requested a review from a team October 24, 2024 17:46
@ctran88 ctran88 merged commit 79bff93 into main Oct 28, 2024
4 checks passed
@ctran88 ctran88 deleted the PSG-5139-fix-release-ci branch October 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants