ci: add e2e test to on-pr workflow #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctran88
force-pushed
the
PSG-5780-sdk-test-go
branch
from
e5381d3 to
93010f3
Compare
ctran88
commented
Jan 22, 2025
| "target_sdk":"go", | ||
| "use_test_release":true, | ||
| "sdk_branch_ref":"${{ github.head_ref || github.ref_name }}", | ||
| "test_release_version":"${{ steps.get_sdk_version.outputs.version }}" |
There was a problem hiding this comment.
this will be an empty string '' if version is not set (no change), which will translate to an empty input for the upstream workflow so that it will grab the version from the release please branch manifest instead
bertrmz
reviewed
Jan 24, 2025
Comment on lines
+64
to
+65
| - name: Get SDK version | ||
| id: get_sdk_version |
There was a problem hiding this comment.
This step looks good. A small suggestion: consider revising the name or adding a comment to clarify how the script will get the version.
bertrmz
approved these changes
Jan 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
runs
Screenshots (if appropriate):
Type of change
Checklist:
Additional context