(PC-31957)[API] feat: include booking with partial finance incident in the beneficiary's credits #14250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meewan
reviewed
Sep 20, 2024
api/src/pcapi/core/users/api.py
Outdated
Comment on lines
780
to
785
| booking_finance_incidents = [ | ||
| booking_finance_incident | ||
| for booking_finance_incident in booking.incidents | ||
| if booking_finance_incident.is_partial | ||
| and booking_finance_incident.incident.status == finance_models.IncidentStatus.VALIDATED | ||
| ] |
There was a problem hiding this comment.
la comprehension list sur 5 ligne, je pense qu'on gagnerait en lisibilité en la déroulant avec une boucle for standard.
thconte
approved these changes
Sep 20, 2024
aminepass
force-pushed
the
pc-31957/finance-incident-domains-credit
branch
from
7931b76
to
cad9b55
Compare
cepehang
approved these changes
Sep 20, 2024
…n the beneficiary's credits
aminepass
force-pushed
the
pc-31957/finance-incident-domains-credit
branch
from
cad9b55
to
07361c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Prise en compte des incidents finance partiels dans le calcul du crédit des bénéficiaires
Exemple:
Un jeune ayant :
Le crédit du jeune doit être à
300€ - 40€ - 27€ = 233€Dans le fonctionnement actuel, on ne prend en considération que les réservations complètement annulées il manquait le calcul des réservations dont on ne prend pas directement le montant depuis
total_amountmais debooking.incidents[0].newTotalAmountTicket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31957
Vérifications