(PC-31961)[API] feat: Delete offers description when linked to a product #14249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mageoffray
force-pushed
the
mageoffray/pc-31961-script-delete-description
branch
from
c9ee6b0
to
d30b0ed
Compare
ogeber
approved these changes
Sep 20, 2024
mageoffray
force-pushed
the
mageoffray/pc-31961-script-delete-description
branch
from
d30b0ed
to
02bd040
Compare
AleksDPass
reviewed
Sep 20, 2024
| ) | ||
| if not_dry: | ||
| db.session.commit() | ||
| if i % vacuum_treshold_rounded == 0: |
There was a problem hiding this comment.
Prenons le cas ou le k*batch size+ starting_id ne tombe jamais sur un mutliple de vacccum_treshold(qui est fixe) avec un interval très important entre start et end et un un start> vacumm_treshold. on ne va pas faire de vaccum même si on traite un vaccum_treshold nombre de lignes.
There was a problem hiding this comment.
Yes en effet, je m'étais dis ça et j'ai ajouté un arrondi pour tomber toujours sur un multiple de 1000.
Mais au final comme j'ai fais un lot qui commence à 1, i vaudra toujours 1, 1001, 2001, ... Et sera jamais un multiple de vacuum_treshold_rounded.
Faut que j'améliore le truc, merci 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31961
Delete description from offers when linked to a product.
We have 255_000_000 offers in our database, only 2_000_000 are not linked to a product. Save the pandas and pinguins by drastically reducing the space used by our offer table (not really, but one day).
According to metabase this column takes 157 Gb (not sure about that)
I'll add timing metrics once it will be tested on staging
Vérifications