(PC-31860)[BO] feat: transfert all PRO links in BO to connect as exte… #14230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroullier-pass
approved these changes
Sep 24, 2024
| def _get_user_id_from_bank_account_id(bank_account_id: int) -> int: | ||
| if not FeatureToggle.WIP_CONNECT_AS_EXTENDED.is_active(): | ||
| raise ValueError( | ||
| "L'utilisation de la version étendue de « connect as » requiert l'activation de la feature : WIP_CONNECT_AS_EXTENDED" |
There was a problem hiding this comment.
Suggested change
| "L'utilisation de la version étendue de « connect as » requiert l'activation de la feature : WIP_CONNECT_AS_EXTENDED" | |
| "L'utilisation de la version étendue de « connect as » requiert l'activation du feature flag : WIP_CONNECT_AS_EXTENDED" |
There was a problem hiding this comment.
c'est le même message que les autres qui ne devrait jamais apparaitre (et qui disparaitra definitivement assez vite) donc je ne vais pas le modifier.
Malheureusement oui, je ne peux pas utiliser les filtres facilement dans links.html. Je ne l'ai fait que pour |
prouzet
force-pushed
the
pc-31860-rpa-connect-as-generalisation
branch
from
f1f2ca5
to
d778152
Compare
|
Je n'ai fait qu'un rebase sur origin/master. |
Meewan
force-pushed
the
pc-31860-rpa-connect-as-generalisation
branch
from
d778152
to
3ad23e2
Compare
Meewan
force-pushed
the
pc-31860-rpa-connect-as-generalisation
branch
from
3ad23e2
to
5169dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nded
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31860
Vérifications