(PC-31907)[API] fix: Export bookings csv/xlsx #14217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damien-ramelet
force-pushed
the
dramelet/PC-31907-fix-bookings-export-when-no-oa
branch
8 times, most recently
from
15e2d37
to
d9ff64a
Compare
| @@ -219,6 +219,7 @@ def when_user_has_rights_on_managing_offerer(self, client, db_session): | |||
| "postalCode": "75000", | |||
| "inseeCode": "75102", | |||
| "city": "Paris", | |||
| "departementCode": 75, | |||
There was a problem hiding this comment.
Suggested change
| "departementCode": 75, | |
| "departementCode": "75", |
Our tests was populated with wrong data. Offers use to had an OffererAddress, while this isn’t the case in reality (yet). Moreover, the joins on the query fetching the rows wasn’t under FF.
damien-ramelet
force-pushed
the
dramelet/PC-31907-fix-bookings-export-when-no-oa
branch
from
d9ff64a
to
774399b
Compare
xordoquy
approved these changes
Sep 19, 2024
damien-ramelet
deleted the
dramelet/PC-31907-fix-bookings-export-when-no-oa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests was populate with wrong data. Offers used to had OffererAddress, while this isn’t the case in reality. Moreover, the joins on the query fetching the rows wasn’t under FF.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31907
Vérifications