Dramelet/bsr yet another flaky test fix #14215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damien-ramelet
force-pushed
the
dramelet/bsr-yet-another-flaky-test-fix
branch
3 times, most recently
from
99665de
to
ce7622e
Compare
As seen in 3fe544a, this test is flaky. A `SELECT * FROM venue` can be issued in the buisness code between the steps `check_stock_is_bookable` and `check_expenses_limits` while the Venue has been successfully joinedload previously. While this issue is unresolved, we don’t want to count the queries as this make this test flaky.
damien-ramelet
force-pushed
the
dramelet/bsr-yet-another-flaky-test-fix
branch
from
ce7622e
to
6058ffe
Compare
francois-pass-culture
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in 3fe544a, this test is flaky.
A
SELECT * FROM venuecan be issued in the buisness code between the stepscheck_stock_is_bookableandcheck_expenses_limitswhile the Venuehas still successfully joinedload previously.
While this issue is unresolved, we don’t want to count the queries
as this make this test flaky.
Vérifications