Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use displayedStatus in collective offers filters and status tag. #14069

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

gmeigniez-pass
Copy link
Contributor

@gmeigniez-pass gmeigniez-pass commented Sep 11, 2024

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30689

Objectif
Utiliser le nouveau champ displayedStatus pour l'affichage des badges des offres collectives dans la liste des offres et dans les pages récap (c'est la même fonction qui gère).
Au passage ajustement des noms des statuts avec les nouvelles specs.

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Visit the preview URL for this PR (updated for commit 85e9b06):

https://pc-pro-testing--pr14069-pc-30689-use-display-mdv5nmms.web.app

(expires Sat, 21 Sep 2024 07:17:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@gmeigniez-pass gmeigniez-pass force-pushed the pc-30689-use-displayedstatus-in-offer-tag branch from 8413cfa to d05cc9e Compare September 12, 2024 10:26
@gmeigniez-pass gmeigniez-pass changed the title WIP Use displayedStatus in collective offers filters and status tag. Sep 12, 2024
@gmeigniez-pass gmeigniez-pass marked this pull request as ready for review September 12, 2024 10:27
@gmeigniez-pass gmeigniez-pass force-pushed the pc-30689-use-displayedstatus-in-offer-tag branch 2 times, most recently from 4485aca to 0cea729 Compare September 17, 2024 10:31
@gmeigniez-pass gmeigniez-pass force-pushed the pc-30689-use-displayedstatus-in-offer-tag branch from 0cea729 to f9e8727 Compare September 17, 2024 15:06
@gmeigniez-pass gmeigniez-pass force-pushed the pc-30689-use-displayedstatus-in-offer-tag branch from f9e8727 to 85e9b06 Compare September 19, 2024 07:06
@gmeigniez-pass gmeigniez-pass merged commit 41d018c into master Sep 20, 2024
18 checks passed
@gmeigniez-pass gmeigniez-pass deleted the pc-30689-use-displayedstatus-in-offer-tag branch September 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants