(PC-31828)[PRO] fix: make EAN search input required on subcat error

pass-culture · Sep 17, 2024 · f6a208b · f6a208b
1 parent fb242ee
commit f6a208b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/pro/src/screens/IndividualOffer/DetailsScreen/DetailsEanSearch/DetailsEanSearch.spec.tsx b/pro/src/screens/IndividualOffer/DetailsScreen/DetailsEanSearch/DetailsEanSearch.spec.tsx
@@ -103,11 +103,14 @@ describe('DetailsEanSearch', () => {
           subcategoryId: 'SUPPORT_PHYSIQUE_MUSIQUE_VINYLE',
         })
 
-        expect(screen.getByText(subCatErrorMessage)).toBeInTheDocument()
-
         const eanInput = screen.getByRole('textbox', { name: inputLabel })
-        await userEvent.type(eanInput, '9781234567897')
 
+        // Input is now required.
+        expect(eanInput).toBeRequired()
+
+        // Error cannot be removed by typing in the input.
+        expect(screen.getByText(subCatErrorMessage)).toBeInTheDocument()
+        await userEvent.type(eanInput, '9781234567897')
         expect(screen.getByText(subCatErrorMessage)).toBeInTheDocument()
       })
 

diff --git a/pro/src/screens/IndividualOffer/DetailsScreen/DetailsEanSearch/DetailsEanSearch.tsx b/pro/src/screens/IndividualOffer/DetailsScreen/DetailsEanSearch/DetailsEanSearch.tsx
@@ -148,6 +148,7 @@ export const DetailsEanSearch = ({
   }
 
   const shouldInputBeDisabled = isProductBased || isFetchingProduct
+  const shouldInputBeRequired = !!subcatError
   const shouldButtonBeDisabled =
     isProductBased || !ean || !!formikError || !!apiError || isFetchingProduct
   const displayClearButton = isNotAnOfferYetButProductBased
@@ -167,7 +168,10 @@ export const DetailsEanSearch = ({
       >
         Nouveau
       </Tag>
-      <span>Scanner ou rechercher un produit par EAN</span>
+      <span>
+        Scanner ou rechercher un produit par EAN
+        {shouldInputBeRequired && ' *'}
+      </span>
     </>
   )
 
@@ -187,7 +191,8 @@ export const DetailsEanSearch = ({
           type="text"
           disabled={shouldInputBeDisabled}
           maxLength={13}
-          isOptional
+          isOptional={!shouldInputBeRequired}
+          showMandatoryAsterisk={false}
           countCharacters
           {...(externalError && {
             externalError,