(PC-31318)[API] fix: handle legacy activity serialization

api/src/pcapi/routes/native/v1/serialization/account.py

@@ -172,9 +172,11 @@ def get(self, key: str, default: typing.Any | None = None) -> typing.Any:
             user_subscription_state = subscription_api.get_user_subscription_state(user)
             return user_subscription_state.subscription_message
         if key == "activityId":
-            if user.activity is None:
+            try:
+                activity = users_models.ActivityEnum(user.activity)
+                return profile_options.ActivityIdEnum(activity.name)
+            except ValueError:
                 return None
-            return profile_options.ActivityIdEnum(users_models.ActivityEnum(user.activity).name)
 
         return super().get(key, default)
 

api/tests/routes/native/v1/account_test.py

@@ -206,6 +206,16 @@ def test_get_user_profile_empty_first_name(self, client, app):
         assert not response.json["isBeneficiary"]
         assert response.json["roles"] == []
 
+    def test_get_user_profile_legacy_activity(self, client):
+        users_factories.UserFactory(email=self.identifier, activity="activity not in enum")
+
+        expected_num_queries = 4  # user + beneficiary_fraud_review + deposit + booking
+        with assert_num_queries(expected_num_queries):
+            response = client.with_token(email=self.identifier).get("/native/v1/me")
+
+        assert response.status_code == 200
+        assert "activity" not in response.json
+
     def test_get_user_profile_recredit_amount_to_show(self, client, app):
         with time_machine.travel("2020-01-01"):
             users_factories.UnderageBeneficiaryFactory(email=self.identifier)