Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-30797) feat(tests): Bump msw from 1 to 2 #6614

Merged
merged 18 commits into from
Jul 26, 2024
Merged

(PC-30797) feat(tests): Bump msw from 1 to 2 #6614

merged 18 commits into from
Jul 26, 2024

Conversation

Lucasbeneston
Copy link
Contributor

@Lucasbeneston Lucasbeneston commented Jun 28, 2024 •
edited by cedricls1
Loading

https://passculture.atlassian.net/browse/PC-30797
https://mswjs.io/docs/migrations/1.x-to-2.x/

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" [on Notion][1]

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Performance Comparison Report

Significant Changes To Render Duration

Name Render Duration Render Count
Performance test for Offer page 266.8 ms → 222.0 ms (-44.8 ms, -16.8%) 🟢 6 → 5 (-1, -16.7%) 🟢
Show details
Name Render Duration Render Count
Performance test for Offer page Baseline
Mean: 266.8 ms
Stdev: 8.0 ms (3.0%)
Runs: 280 277 271 270 269 264 264 259 258 256

Current
Mean: 222.0 ms
Stdev: 7.7 ms (3.5%)
Runs: 235 231 231 222 220 219 218 217 215 212		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Favorites page 55.8 ms → 57.9 ms (+2.1 ms, +3.8%) 6 → 6
Performance test for Bookings page 39.1 ms → 40.3 ms (+1.2 ms, +3.1%) 7 → 7
Search Results - Performance test for Search Results page 14.5 ms → 15.0 ms (+0.5 ms, +3.4%) 5 → 5
Performance test for Profile page 6.5 ms → 7.0 ms (+0.5 ms, +7.7%) 5 → 5
Search Landing Page - Performance test for Search Landing page 13.5 ms → 13.9 ms (+0.4 ms, +3.0%) 5 → 5
Performance test for EndedBookings page 29.9 ms → 30.0 ms (+0.1 ms, ±0.0%) 7 → 7
Performance test for Venue page 2.4 ms → 2.5 ms (+0.1 ms, +4.2%) 1 → 1
Show details
Name Render Duration Render Count
Performance test for Favorites page Baseline
Mean: 55.8 ms
Stdev: 2.0 ms (3.6%)
Runs: 59 57 57 57 56 56 56 54 54 52

Current
Mean: 57.9 ms
Stdev: 1.9 ms (3.3%)
Runs: 62 60 59 58 57 57 57 57 56 56		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Bookings page Baseline
Mean: 39.1 ms
Stdev: 0.7 ms (1.9%)
Runs: 40 40 40 39 39 39 39 39 38 38

Current
Mean: 40.3 ms
Stdev: 1.1 ms (2.6%)
Runs: 42 41 41 41 41 40 40 39 39 39		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Search Results - Performance test for Search Results page Baseline
Mean: 14.5 ms
Stdev: 1.6 ms (11.4%)
Runs: 18 16 16 14 14 14 14 13 13 13

Current
Mean: 15.0 ms
Stdev: 1.6 ms (10.9%)
Runs: 17 17 16 16 15 15 15 14 13 12		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page Baseline
Mean: 6.5 ms
Stdev: 1.0 ms (15.0%)
Runs: 8 8 7 7 6 6 6 6 6 5

Current
Mean: 7.0 ms
Stdev: 1.2 ms (17.8%)
Runs: 9 8 8 8 7 7 6 6 6 5		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 13.5 ms
Stdev: 1.9 ms (14.1%)
Runs: 16 16 15 14 14 13 13 12 12 10

Current
Mean: 13.9 ms
Stdev: 1.4 ms (10.4%)
Runs: 16 15 15 15 15 13 13 13 12 12		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 29.9 ms
Stdev: 1.5 ms (5.1%)
Runs: 32 31 31 31 30 30 30 29 28 27

Current
Mean: 30.0 ms
Stdev: 1.2 ms (4.2%)
Runs: 32 31 31 31 30 30 29 29 29 28		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Venue page Baseline
Mean: 2.4 ms
Stdev: 0.5 ms (21.5%)
Runs: 3 3 3 3 2 2 2 2 2 2

Current
Mean: 2.5 ms
Stdev: 0.7 ms (28.3%)
Runs: 3 3 3 3 3 3 2 2 2 1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Changes To Render Count

Name Render Duration Render Count
Performance test for Offer page 266.8 ms → 222.0 ms (-44.8 ms, -16.8%) 🟢 6 → 5 (-1, -16.7%) 🟢
Show details
Name Render Duration Render Count
Performance test for Offer page Baseline
Mean: 266.8 ms
Stdev: 8.0 ms (3.0%)
Runs: 280 277 271 270 269 264 264 259 258 256

Current
Mean: 222.0 ms
Stdev: 7.7 ms (3.5%)
Runs: 235 231 231 222 220 219 218 217 215 212		 Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against c4be6a2

@cedricls1 cedricls1 force-pushed the bump-msw-from-1-to-2 branch 8 times, most recently from e4bafb9 to 7a89ad4 Compare July 11, 2024 12:06
@cedricls1 cedricls1 changed the title (BSR) feat(tests): Bump msw from 1 to 2 (PC-30797) feat(tests): Bump msw from 1 to 2 Jul 11, 2024
@cedricls1 cedricls1 force-pushed the bump-msw-from-1-to-2 branch 4 times, most recently from ad71db9 to e898793 Compare July 11, 2024 12:42
@inesmouandjolobe inesmouandjolobe marked this pull request as ready for review July 24, 2024 15:54
bruno-ebstein-pass-culture
bruno-ebstein-pass-culture approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il faudra push les trucs qu'on a vu ensemble

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@inesmouandjolobe inesmouandjolobe merged commit be07e69 into master Jul 26, 2024
50 checks passed
@inesmouandjolobe inesmouandjolobe deleted the bump-msw-from-1-to-2 branch July 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inesmouandjolobe inesmouandjolobe inesmouandjolobe left review comments

@bruno-ebstein-pass-culture bruno-ebstein-pass-culture bruno-ebstein-pass-culture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lucasbeneston @bruno-ebstein-pass-culture @inesmouandjolobe @cepehang