Do not include referrerCode in cta_url (#11539)

Co-authored-by: Rémi <[email protected]>
parti-renaissance · Feb 28, 2025 · f14d954 · f14d954
1 parent d3b7deb
commit f14d954
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/features/api/alerts.feature b/features/api/alerts.feature
@@ -16,7 +16,7 @@ Feature:
                     "title": "Venez nombreux !",
                     "description": "",
                     "cta_label": "Je réserve ma place",
-                    "cta_url": "http://test.renaissance.code/connexion-avec-un-lien-magique?@string@&_target_path=%2Fgrand-rassemblement%2Fevent-national-1%2F@string@",
+                    "cta_url": "http://test.renaissance.code/connexion-avec-un-lien-magique?@string@&_target_path=%2Fgrand-rassemblement%2Fevent-national-1",
                     "image_url": null,
                     "share_url": "http://inscription.besoindeurope.code/grand-rassemblement/event-national-1/@string@"
                 },

diff --git a/src/JeMengage/Alert/Provider/MeetingProvider.php b/src/JeMengage/Alert/Provider/MeetingProvider.php
@@ -34,7 +34,7 @@ public function getAlerts(Adherent $adherent): array
             $ctaUrl = '';
             $imageUrl = null;
             $currentUser = $this->getCurrentUser();
-            $eventInscriptionUrl = $currentUser
+            $shareUrl = $currentUser
                 ? $this->urlGenerator->generate(
                     'app_national_event_by_slug_with_referrer',
                     [
@@ -60,11 +60,20 @@ public function getAlerts(Adherent $adherent): array
                 $ctaUrl = $this->loginLinkHandler->createLoginLink(
                     $adherent,
                     lifetime: 3600,
-                    targetPath: parse_url($eventInscriptionUrl, \PHP_URL_PATH),
+                    targetPath: parse_url(
+                        $this->urlGenerator->generate(
+                            'app_national_event_by_slug',
+                            [
+                                'slug' => $event->getSlug(),
+                            ],
+                            UrlGeneratorInterface::ABSOLUTE_URL
+                        ),
+                        \PHP_URL_PATH
+                    ),
                 )->getUrl();
             }
 
-            $alerts[] = $alert = Alert::createMeeting($event, $ctaLabel, $ctaUrl, $imageUrl, $eventInscriptionUrl);
+            $alerts[] = $alert = Alert::createMeeting($event, $ctaLabel, $ctaUrl, $imageUrl, $shareUrl);
             $alert->date = $event->startDate;
         }