Merge pull request #297 from EnMarche/fix/sentry-back-error-logging

ETQDev, je ne vois pas les erreurs lors des call au back catchés dans Sentry

src/redux/useTypedAsyncFn.ts

@@ -1,5 +1,4 @@
 import { useAsyncFn } from 'react-use';
-import * as Sentry from '@sentry/browser';
 
 /**
  * A wrapper around useAsyncFn until its arguments can be properly typed
@@ -12,11 +11,6 @@ import * as Sentry from '@sentry/browser';
 
 export function useTypedAsyncFn<T>(callback: (input: T) => Promise<any>, deps: any[]) {
   return useAsyncFn(async (...args: T[]) => {
-    try {
-      return await callback(args[0]);
-    } catch (err) {
-      Sentry.captureException(err);
-      throw err;
-    }
+    return await callback(args[0]);
   }, deps);
 }

src/services/HandleErrorService.ts

@@ -1,7 +1,8 @@
+import debounce from 'lodash/debounce';
+import * as Sentry from '@sentry/browser';
 import { store } from 'redux/store';
 import { updateSnackbar } from 'redux/Snackbar';
 import { Severity } from 'redux/Snackbar/types';
-import debounce from 'lodash/debounce';
 
 export type APIErrorsType = Response | Error;
 type DefaultHandlerType = (error?: APIErrorsType) => string | null;
@@ -28,7 +29,11 @@ export default class HandleErrorService {
       return defaultMessage;
     }
     const errorMessage = defaultHandler(error);
-    return errorMessage !== null ? errorMessage : defaultMessage;
+    if (errorMessage !== null) {
+      return errorMessage;
+    }
+    Sentry.captureException(error);
+    return defaultMessage;
   }
 
   static getErrorMessage(error?: APIErrorsType, defaultHandler?: DefaultHandlerType) {
@@ -41,6 +46,7 @@ export default class HandleErrorService {
     } else if (error instanceof Response && HandleErrorService.isNoBackConnectionError(error)) {
       return ERROR_MESSAGES.unableToJoinServer;
     } else if (error instanceof Response && error.status >= 500) {
+      Sentry.captureException(error);
       return ERROR_MESSAGES.error500;
     }