Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for face-centered fields #736

Closed
10 of 13 tasks
Yurlungur opened this issue Oct 4, 2022 · 4 comments · Fixed by #904
Closed
10 of 13 tasks

Plan for face-centered fields #736

Yurlungur opened this issue Oct 4, 2022 · 4 comments · Fixed by #904

Comments

@Yurlungur
Copy link
Collaborator

Yurlungur commented Oct 4, 2022

From Hackathon:

  • Cell vars generalized to become differently shaped fields
  • Generalize "WithFluxes" to be more verbose about what kind of fluxes
  • "EMF correction" implemented as "line integral correction"
  • Keep in mind concern about order of operations

TODOS:

@Yurlungur
Copy link
Collaborator Author

Additional note: AMR load balance is missing some logic for tensor-valued quantities to communicate tensor values accross mesh boundaries. We need to repeat what @brryan did for buffer packing.

@Yurlungur Yurlungur mentioned this issue Oct 27, 2022
7 tasks
@lroberts36
Copy link
Collaborator

One of the TODOs is to "Add metadata", does anyone know what this refers to? It looks like metadata already exists for faces, edges, and nodes. Is is just referring to update metadata to change the shapes of variables based on their topological type?

@pgrete
Copy link
Collaborator

pgrete commented May 2, 2023

Good question. Your first guess would have also been mine.

@lroberts36 lroberts36 pinned this issue May 2, 2023
@Yurlungur
Copy link
Collaborator Author

I'm not sure either. Let's just check it off lol.

@lroberts36 lroberts36 linked a pull request Jul 13, 2023 that will close this issue
16 tasks
@lroberts36 lroberts36 unpinned this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants