Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check boundary tasks in examples #1212

Open
pgrete opened this issue Nov 25, 2024 · 1 comment
Open

Check boundary tasks in examples #1212

pgrete opened this issue Nov 25, 2024 · 1 comment
Labels
good first issue Good for newcomers refactor An improvement to existing code.

Comments

@pgrete
Copy link
Collaborator

pgrete commented Nov 25, 2024

I just noticed that some example use AddBoundaryExchangeTasks and also set physical boundaries afterwards again.
As far as I can tell, this is not necessary and could be cleaned up.

@pgrete pgrete added good first issue Good for newcomers refactor An improvement to existing code. labels Nov 25, 2024
@pgrete pgrete changed the title Check tasks in examples Check boundary tasks in examples Nov 25, 2024
@Yurlungur
Copy link
Collaborator

Can confirm this can be cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor An improvement to existing code.
Projects
None yet
Development

No branches or pull requests

2 participants