Skip to content

add cache information in About API #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 4, 2024
Merged

add cache information in About API #597

merged 5 commits into from
Jan 4, 2024

Conversation

nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Jan 4, 2024 •
edited by nitisht
Loading

Fixes #593

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht changed the title Fix for PR:593: Added Cache information in the About API add cache information in About API Jan 4, 2024
@nitisht nitisht self-requested a review January 4, 2024 07:26
@nitisht nitisht mentioned this pull request Jan 4, 2024
Merged
@nitisht nitisht merged commit 1fcbd4e into parseablehq:main Jan 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About API does not have the details of Global Caching - Cache Dir and Cache Size
2 participants
@nikhilsinhaparseable @nitisht