Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help messages for environment variables / flags #588

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix help messages for environment variables / flags #588

merged 2 commits into from
Dec 29, 2023

Conversation

nitisht
Copy link
Member

@nitisht nitisht commented Dec 24, 2023 •
edited
Loading

This PR also adds

  • fix startup check for cache size and improve the error message
  • gRPC port number in startup banner.
  • Human readable input for size / capacity type environment variable

Fixes #586

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht requested a review from theteachr December 24, 2023 18:37
theteachr
theteachr suggested changes Dec 25, 2023
View reviewed changes
server/src/banner.rs Show resolved Hide resolved
server/src/option.rs Outdated Show resolved Hide resolved
server/src/option.rs Outdated Show resolved Hide resolved
server/src/utils.rs Outdated Show resolved Hide resolved
@nitisht
Copy link
Member Author

nitisht commented Dec 25, 2023

I'll clean this up once #585 is merged

@nitisht
Update helm messages for each cli / env var setting
6b79331 
Also fix startup check for cache size and improve the error
message.

Fixes parseablehq#586
@nitisht nitisht merged commit a3f9ccb into parseablehq:main Dec 29, 2023
6 checks passed
@nitisht nitisht deleted the help-text branch December 29, 2023 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theteachr theteachr theteachr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: incorrect help message for several fields
2 participants
@nitisht @theteachr