Skip to content

make about utils public #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nitisht merged 4 commits into from
Jan 8, 2025
Merged

make about utils public #1083

nitisht merged 4 commits into from
Jan 8, 2025

Conversation

@nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Jan 8, 2025

No description provided.

@coveralls
Copy link

coveralls commented Jan 8, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12666781927

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.354%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/modal/server.rs 0 1 0.0%
src/handlers/http/modal/ingest_server.rs 0 4 0.0%
src/handlers/http/modal/query_server.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 12664608381: 0.0%
Covered Lines: 2407
Relevant Lines: 19483
💛 - Coveralls

de-sh
de-sh reviewed Jan 8, 2025
View reviewed changes
@nitisht @de-sh
Update src/storage/mod.rs
cea5e67 
Co-authored-by: Devdutt Shenoi <[email protected]>
Signed-off-by: Nitish Tiwari <[email protected]>
@nitisht nitisht merged commit 8b73d42 into parseablehq:main Jan 8, 2025
6 checks passed
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jan 13, 2025
@nikhilsinhaparseable @nitisht
@de-sh @parmesant
chore: make utils public (parseablehq#1083)
a7289df 
Signed-off-by: Nitish Tiwari <[email protected]>
Co-authored-by: Nitish Tiwari <[email protected]>
Co-authored-by: Devdutt Shenoi <[email protected]>
@nikhilsinhaparseable nikhilsinhaparseable deleted the pub-about branch July 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@de-sh de-sh de-sh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikhilsinhaparseable @coveralls @de-sh @nitisht