Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RS-W1070) Found use of .clone() in assignment #519

Closed
nitisht opened this issue Sep 27, 2023 · 0 comments · Fixed by #520
Closed

(RS-W1070) Found use of .clone() in assignment #519

nitisht opened this issue Sep 27, 2023 · 0 comments · Fixed by #520
Assignees
@trueleo

Comments

@nitisht
Copy link
Member

nitisht commented Sep 27, 2023

Description

Consider using .clone_from() instead of assigning the result of .clone(). clone_from() may perform better in some cases because some structs may have custom implementations of clone_from(), which improve performance by avoiding needless allocations.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → app.deepsource.com/gh/parseablehq/parseable/issue/RS-W1070/occurrences/
nitisht added a commit to nitisht/parseable that referenced this issue Sep 29, 2023
@nitisht
Use clone_from() as it performs better in some cases
4697f85 
Fixes parseablehq#519
@nitisht nitisht mentioned this issue Sep 29, 2023
Merged
3 tasks
nitisht added a commit to nitisht/parseable that referenced this issue Sep 29, 2023
@nitisht
Use clone_from() as it performs better in some cases
6c15047 
Fixes parseablehq#519
nitisht added a commit that referenced this issue Sep 30, 2023
@nitisht
Use clone_from() as it performs better in some cases (#520)
3d6e8c8 
Also update github workflow to use new quest format

Fixes #519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trueleo trueleo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use clone_from() as it performs better in some cases nitisht/parseable
2 participants
@nitisht @trueleo