Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default role for new oidc user #513

Closed
trueleo opened this issue Sep 20, 2023 · 0 comments · Fixed by #517
Closed

Add default role for new oidc user #513

trueleo opened this issue Sep 20, 2023 · 0 comments · Fixed by #517
Assignees
@trueleo
Labels
enhancement New feature or request
Milestone
Release v0.7.1

Comments

@trueleo
Copy link
Contributor

trueleo commented Sep 20, 2023 •
edited
Loading

Description

In 0.7 we explicitly need to have 'group' claim in the ID Token for role assignment to work. In some cases it may be desirable to give default role to new user logging into the page.

Proposal

create a special role parseable:public that can be configured with role api. In cases where group claim is not found or group claim is insufficient we fallback to assigning this role to user so that console works for them.
@trueleo trueleo changed the title Add default role for new user Add default role for new oidc user Sep 20, 2023
@nitisht nitisht added this to the Release v0.7.1 milestone Sep 22, 2023
@nitisht nitisht added the enhancement New feature or request label Sep 22, 2023
@trueleo trueleo mentioned this issue Sep 26, 2023
Merged
3 tasks
nitisht pushed a commit that referenced this issue Sep 27, 2023
@trueleo
add default role api (#517)
1a1c340 
This PR adds an API to set default role to be 
assigned to any new OIDC user. This is needed 
for identity providers like Google where there is 
no group membership for a given user.

Fixes #513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trueleo trueleo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v0.7.1
Development

Successfully merging a pull request may close this issue.

Add default role api trueleo/parseable
2 participants
@nitisht @trueleo