Fix leak warnings in tests, use mongodb-runner from node_modules #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew-gross
force-pushed
the
improve-tests
branch
from
b9c55b9
to
e074a92
Compare
| }); | ||
| //This causes tests to spew some useless warnings, so disable in test | ||
| if (!process.env.TESTING) { | ||
| process.on('uncaughtException', (err) => { |
There was a problem hiding this comment.
Why do we even have that in here as we don't listen directly?
There was a problem hiding this comment.
This is to improve the error message when people try to run their app when it's already running. Since adding this the number of bug reports caused by that have dropped to zero so I'd say it's valuable code.
Current coverage is
|
flovilmart
added a commit
that referenced
this pull request
Mar 5, 2016
Fix leak warnings in tests, use mongodb-runner from node_modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the amount of garbage spewed to the console in tests.