Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #7018

Closed
wants to merge 1 commit into from
Closed

Conversation

MichaelJCole
Copy link

mongodb-runner has a node 14 problem, which breaks the introduction for new user.

mongodb-runner has a node 14 problem.
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #7018 (8e7b51d) into master (c958c46) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7018      +/-   ##
==========================================
- Coverage   93.85%   93.81%   -0.05%     
==========================================
  Files         169      169              
  Lines       12415    12415              
==========================================
- Hits        11652    11647       -5     
- Misses        763      768       +5     
Impacted Files Coverage Δ
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.92% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.67% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c958c46...8e7b51d. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Nov 20, 2020

Looks like this issue has been addressed mongodb-js/runner#174

Waiting for a release. (Hasn't been a release in 10 months)

@MichaelJCole
Copy link
Author

This is a patch for the README.md to include information for visitors evaluating Parse.

It does not relate to code coverage. @codecov you are a wrong robot.

While the referenced patch might fix this startup issue, it seems prudent to still include the warning in case of other compatibility issues w/ node 14+.

@dplewis
Copy link
Member

dplewis commented Dec 8, 2020

Thanks for the PR. This issue has been addressed in #7029.

@dplewis dplewis closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants