Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Transform input types also on user mutations #6934

Merged

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Oct 9, 2020

It seems that we miss to transform types on signup/loginwith

@Moumouls Moumouls added the type:bug Impaired feature or lacking behavior that is likely assumed label Oct 9, 2020
@Moumouls Moumouls self-assigned this Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #6934 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6934      +/-   ##
==========================================
- Coverage   93.81%   93.80%   -0.01%     
==========================================
  Files         169      169              
  Lines       12216    12219       +3     
==========================================
+ Hits        11460    11462       +2     
- Misses        756      757       +1     
Impacted Files Coverage Δ
src/GraphQL/loaders/usersMutations.js 93.50% <100.00%> (+0.26%) ⬆️
src/RestWrite.js 93.82% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8c9ff...e458be2. Read the comment docs.

@Moumouls
Copy link
Member Author

Moumouls commented Oct 9, 2020

don't know why travis fail, it seems to have a strange timeout The job exceeded the maximum time limit for jobs, and has been terminated.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 5693470 into parse-community:master Oct 9, 2020
@mtrezza mtrezza removed the type:bug Impaired feature or lacking behavior that is likely assumed label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants