-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set objectId into query for Email Validation #6930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6930 +/- ##
==========================================
- Coverage 93.81% 93.77% -0.04%
==========================================
Files 169 169
Lines 12216 12218 +2
==========================================
- Hits 11460 11458 -2
- Misses 756 760 +4
Continue to review full report at Codecov.
|
Thanks for the PR. Could you please run |
Lint ok ! For regression test, i have no idea how to do that, can you give me some help ? |
Take a look at this file: https://github.com/parse-community/parse-server/blob/master/spec/ParseLiveQuery.spec.js You need to create a new test case similar to these ones that reproduces the problem that you are trying to solve. This test case should not pass before your change and pass after your change. |
Working on it ;) |
Test done ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Only a small suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #6921
It seems that LiveQueryController need original object id to send event.
But, email validation was not retrieving the user validating email address.