Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutating beforeSubscribe Query #6868

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Aug 19, 2020

Fixes #6866, and now allows returning a new query.

Also adds additional test cases for beforeSubscribe. Failing tests are not related to this PR.

@mtrezza, any other tests required to make sure it's 100%?

@dplewis
Copy link
Member

dplewis commented Aug 20, 2020

@dblythy Can you rebase from master branch? This will fix the failing tests.

@dblythy
Copy link
Member Author

dblythy commented Aug 21, 2020

@dplewis thank you for fixing the other tests! Still one test failing for me:

  1. Parse.Push does not get stuck with _PushStatus 'running' on many installations added
    Message:
    Expected 'running' to equal 'succeeded'

Is this related to my PR?

@mtrezza
Copy link
Member

mtrezza commented Aug 23, 2020

Is this related to my PR?

Most likely not. You can try to close and reopen this PR and see whether the test passes. We are having an issue with intermittently failing test cases which may be the reason why this test fails.

@mtrezza mtrezza closed this Aug 23, 2020
@mtrezza mtrezza reopened this Aug 23, 2020
@davimacedo
Copy link
Member

I believe this PR is failing for Postgres tests.

@dblythy
Copy link
Member Author

dblythy commented Aug 24, 2020

Any ideas why @davimacedo? The travis-ci logs aren't providing anything useful.

@davimacedo
Copy link
Member

Nevermind. It was actually intermittently failing.

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #6868 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6868      +/-   ##
==========================================
+ Coverage   93.78%   93.81%   +0.02%     
==========================================
  Files         168      168              
  Lines       12185    12189       +4     
==========================================
+ Hits        11428    11435       +7     
+ Misses        757      754       -3     
Impacted Files Coverage Δ
src/triggers.js 92.20% <100.00%> (+0.10%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.58% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff0ea9...31bbbf2. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Aug 24, 2020

I restarted the job. Looks good.

@dplewis dplewis merged commit 5743d75 into parse-community:master Aug 25, 2020
@dblythy
Copy link
Member Author

dblythy commented Aug 25, 2020

Thank you gents!!

@dblythy dblythy deleted the beforeSubscribe branch October 5, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeSubscribe doesnt change incoming query
4 participants