GraphQL: Simplify GraphQL merge system to avoid js ref bugs #6791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moumouls
added
type:bug
Moumouls
requested review from
davimacedo,
mtrezza,
omairvaiyani and
douglasmuraoka
Codecov Report
@@ Coverage Diff @@
## master #6791 +/- ##
==========================================
+ Coverage 93.88% 93.91% +0.03%
==========================================
Files 169 169
Lines 12048 12053 +5
==========================================
+ Hits 11311 11320 +9
+ Misses 737 733 -4
Continue to review full report at Codecov.
|
Merged
mtrezza
removed
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in intensive use i notice that sometimes the GraphQL merge is not merged correctly, some object js refs are not merged correctly. With this system in 2 step, we avoid some weird bugs in the GraphQL schema resolution.