GraphQL: Change Order Enum Strategy #6515
Conversation
Moumouls
added
the
type:bug
Codecov Report
@@ Coverage Diff @@
## master #6515 +/- ##
==========================================
+ Coverage 94.01% 94.03% +0.02%
==========================================
Files 169 169
Lines 11825 11866 +41
==========================================
+ Hits 11117 11158 +41
Misses 708 708
Continue to review full report at Codecov.
|
|
A more long term approach would be to use https://www.npmjs.com/package/graphql-tools-fork, following gatsby and graphql-toolkit. Happy to help |
|
That would be great @yaacovCR . Feel free to open a PR. |
|
Sounds good, does this change come with any failing tests to check? |
|
No failing tests were added. That's my bad. I should had requested @Moumouls to do so. But I was able to reproduce this issue myself. You just need to extend the graphql auto schema and then perform any sort in any query. I can try to write something if you need it. |
|
I kind of need it. :) I want to be sure when I switch to fork and revert this patch that it still all works. |
|
Just sent the PR: #6537 You can continue the development over that branch |
|
This is now fixed in upstream graphql-tools as well in v5 which merges fork. |
|
See #6611 |
* Add test case for order option when extending the schema * Remove fit * upgrade to graphql-tools v5 revert #6515 Co-authored-by: Antonio Davi Macedo Coelho de Castro <[email protected]>
mtrezza
removed
the
type:bug
Due to ardatan/graphql-tools#1206, enums with custom value are not correctly merged and lead to bugs and validation error.
We need to transform GraphQL Order to Parse Order later before sending request to Parse Server.
This bug only occur on merged schemas.