Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Fix File on nested upload #6507

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

Moumouls
Copy link
Member

In some mutations due to optimization, url is missing into the file return. So we need to include it into the return.

@Moumouls Moumouls added the type:bug Impaired feature or lacking behavior that is likely assumed label Mar 14, 2020
@Moumouls Moumouls self-assigned this Mar 14, 2020
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #6507 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6507      +/-   ##
==========================================
+ Coverage   94.01%   94.04%   +0.03%     
==========================================
  Files         169      169              
  Lines       11825    12259     +434     
==========================================
+ Hits        11117    11529     +412     
- Misses        708      730      +22     
Impacted Files Coverage Δ
src/GraphQL/transformers/mutation.js 95.86% <100.00%> (-0.73%) ⬇️
src/GraphQL/loaders/defaultRelaySchema.js 91.66% <0.00%> (-3.34%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.79% <0.00%> (-0.68%) ⬇️
src/GraphQL/loaders/defaultGraphQLTypes.js 96.52% <0.00%> (-0.54%) ⬇️
src/GraphQL/loaders/parseClassQueries.js 97.53% <0.00%> (-0.43%) ⬇️
src/GraphQL/loaders/parseClassTypes.js 93.93% <0.00%> (-0.30%) ⬇️
src/RestWrite.js 93.64% <0.00%> (-0.17%) ⬇️
src/Adapters/Auth/apple.js 100.00% <0.00%> (ø)
src/Adapters/Auth/instagram.js 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c10d9e...a95cea1. Read the comment docs.

@davimacedo davimacedo merged commit b6506de into parse-community:master Mar 23, 2020
@mtrezza mtrezza removed the type:bug Impaired feature or lacking behavior that is likely assumed label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants