Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: Introduce ReadOptionsInput #6030

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

davimacedo
Copy link
Member

This PR introduces the ReadOptionsInput to encapsulate the read preferences and other options that can be needed in the future.

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #6030 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6030      +/-   ##
==========================================
+ Coverage    93.9%   93.93%   +0.03%     
==========================================
  Files         164      164              
  Lines       11084    11090       +6     
==========================================
+ Hits        10408    10417       +9     
+ Misses        676      673       -3
Impacted Files Coverage Δ
src/GraphQL/loaders/parseClassQueries.js 97.67% <100%> (+0.11%) ⬆️
src/GraphQL/loaders/parseClassTypes.js 94.47% <100%> (+0.03%) ⬆️
src/GraphQL/loaders/defaultGraphQLTypes.js 96.31% <100%> (+0.04%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.94% <0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac40bf6...063f715. Read the comment docs.

Copy link
Contributor

@douglasmuraoka douglasmuraoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davimacedo davimacedo merged commit 1361bb3 into parse-community:master Sep 12, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants