refactor(GraphQL): Pointer constraint input type as ID #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefines the Pointer constraint input type from a custom scalar to a simple ID.
Codecov Report
@@ Coverage Diff @@
## master #6020 +/- ##
=========================================
+ Coverage 93.22% 93.93% +0.7%
=========================================
Files 164 164
Lines 11106 11084 -22
=========================================
+ Hits 10354 10412 +58
+ Misses 752 672 -80
Continue to review full report at Codecov.
|
davimacedo
requested changes
Sep 4, 2019
| ), | ||
| _nin: defaultGraphQLTypes._nin( | ||
| new GraphQLList(defaultGraphQLTypes.OBJECT_ID) | ||
| ), | ||
| _exists: defaultGraphQLTypes._exists, | ||
| _select: defaultGraphQLTypes._select, |
There was a problem hiding this comment.
I think we should also improve these following 4 operators. But we can address it in a separate PR. I will take a note in the project.
davimacedo
reviewed
Sep 4, 2019
| @@ -284,30 +202,6 @@ const load = ( | |||
| classGraphQLUpdateType | |||
| ); | |||
|
|
|||
| const classGraphQLPointerTypeName = `${graphQLClassName}PointerInput`; | |||
There was a problem hiding this comment.
Why are you removing this one?
There was a problem hiding this comment.
That was a mistake, thanks for noticing it. It was supposed to remove only the Pointer scalar type.
davimacedo
approved these changes
Sep 4, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…ty#6020) * refactor(GraphQL): Pointer constraint input type as ID Redefines the Pointer constraint input type from a custom scalar to a simple ID. * fix: PR review requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefines the Pointer constraint input type from a custom scalar to
a simple ID.