added support for line auth #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Can you add test cases and lint your code? npm run lint |
Codecov Report
@@ Coverage Diff @@
## master #6007 +/- ##
==========================================
- Coverage 93.74% 93.61% -0.14%
==========================================
Files 156 157 +1
Lines 10939 10950 +11
==========================================
- Hits 10255 10251 -4
- Misses 684 699 +15
Continue to review full report at Codecov.
|
|
@dplewis I have modified authorization adapter's test to cover line's auth adapter inclusion. Let me know if anything needs to be done from my end. |
|
Can you improve the test coverage? |
The code coverage of the edited/added codes seems alright. It is affecting other modules. Any insights about it? |
dplewis
approved these changes
Sep 3, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* added support for line auth * fixed linting issues * modified auth adapter spec to handle line auth adapter * revert package.json changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for Line's OAuth Authentication.