-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for protectedFields when using Find without constraints. #5967
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
17 similar comments
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
- Coverage 93.71% 83.01% -10.7%
==========================================
Files 156 156
Lines 10926 10926
==========================================
- Hits 10239 9070 -1169
- Misses 687 1856 +1169
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. LGTM!
Thanks :) |
This PR has two test cases.
I found a bug last week. I talked about this with @davimacedo .
https://community.parseplatform.org/t/protectedfields-vs-usersensitivefields/616/6
Now, this bug already fixed by #5951
But It needs to add some cases for finding users without constraints.