Handle shutdown on grid adapters #5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5943 +/- ##
==========================================
- Coverage 93.68% 93.67% -0.01%
==========================================
Files 156 156
Lines 10842 10850 +8
==========================================
+ Hits 10157 10164 +7
- Misses 685 686 +1
Continue to review full report at Codecov.
|
dplewis
approved these changes
Aug 19, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Handle shutdown on grid adapters * Add tests * Fix postgres test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Grid Adapters are currently not handling the shutdown. It means that if someone start the Parse Server using the CLI, then create a file, then try to close the process, the process never finishes because the connections are not properly closed.