Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested operations from GraphQL API #5931

Merged
merged 8 commits into from
Aug 17, 2019

Conversation

davimacedo
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #5931 into master will decrease coverage by 0.04%.
The diff coverage is 87.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5931      +/-   ##
==========================================
- Coverage   93.73%   93.68%   -0.05%     
==========================================
  Files         156      156              
  Lines       10870    10838      -32     
==========================================
- Hits        10189    10154      -35     
- Misses        681      684       +3
Impacted Files Coverage Δ
src/GraphQL/loaders/schemaDirectives.js 94.44% <ø> (-0.56%) ⬇️
src/GraphQL/ParseGraphQLServer.js 93.02% <0%> (ø) ⬆️
src/GraphQL/loaders/parseClassQueries.js 97.56% <100%> (ø) ⬆️
src/GraphQL/loaders/objectsMutations.js 97.22% <100%> (-0.28%) ⬇️
src/GraphQL/loaders/defaultGraphQLQueries.js 100% <100%> (ø) ⬆️
src/GraphQL/loaders/usersQueries.js 96.29% <100%> (-0.58%) ⬇️
src/GraphQL/ParseGraphQLSchema.js 96.77% <100%> (-0.68%) ⬇️
src/GraphQL/loaders/objectsQueries.js 97.01% <100%> (-0.17%) ⬇️
src/GraphQL/loaders/functionsMutations.js 100% <100%> (ø) ⬆️
src/GraphQL/loaders/parseClassMutations.js 97.7% <100%> (-1.15%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab9dcd...552db34. Read the comment docs.

src/GraphQL/ParseGraphQLSchema.js Outdated Show resolved Hide resolved
src/GraphQL/loaders/functionsMutations.js Outdated Show resolved Hide resolved
@davimacedo
Copy link
Member Author

I think we should also later improve the callCloudCode to receive from a FunctionEnum, instead of a String. I will add the task in the project.

@Moumouls Moumouls merged commit ee5aeea into parse-community:master Aug 17, 2019
@Moumouls
Copy link
Member

@davimacedo I think above all that we will have to think in the long term about how to integrate cloud function more cleanly (enum is a first step) into the graphql server, or even recommend using custom resolvers instead.

@davimacedo
Copy link
Member Author

davimacedo commented Aug 17, 2019

In my opinion, I think that the custom resolvers solve the problem of cloud code functions integration to the GraphQL API. The callCloudCode is a convenient method to test something you are still developing though and I wouldn't remove it (as we did with the class generic operations). But I am open to new ideas.

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Remove nested operations

* Improve error log

* Fix bug schema to load

* Fix ParseGraphQLSchema tests

* Fix tests

* Fix failing tests

* Rename call to callCloudCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants