Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Undefined dot notation in matchKeyInQuery #5917

Merged
merged 7 commits into from
Aug 14, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 14, 2019

Fixes: #5030, #4740

Fixes an uncaught error occurs if the first part of the dot notation is undefined aka key in json didn't exist.

Thanks to @JacobJT for doing the heavy lifting.

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #5917 into master will decrease coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5917      +/-   ##
==========================================
- Coverage   93.73%   93.67%   -0.07%     
==========================================
  Files         153      153              
  Lines       10773    10777       +4     
==========================================
- Hits        10098    10095       -3     
- Misses        675      682       +7
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.67% <100%> (ø) ⬆️
src/RestQuery.js 95.44% <83.33%> (-0.19%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470bb23...655d8c9. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught error while using DOT '.' notation on undefined field
2 participants