Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Logger print JSON and Numbers #5916

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Fix: Logger print JSON and Numbers #5916

merged 2 commits into from
Aug 14, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 14, 2019

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2019 •
edited
Loading

Codecov Report

Merging #5916 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5916      +/-   ##
==========================================
+ Coverage   93.71%   93.72%   +<.01%     
==========================================
  Files         153      153              
  Lines       10769    10769              
==========================================
+ Hits        10092    10093       +1     
+ Misses        677      676       -1
Impacted Files Coverage Δ
src/Adapters/Logger/WinstonLogger.js 100% <ø> (ø) ⬆️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6760ceb...55c6adf. Read the comment docs.

davimacedo
davimacedo approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 470bb23 into master Aug 14, 2019
@TomWFox TomWFox deleted the logger-json-number branch August 14, 2019 13:04
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis @davimacedo
Fix: Logger print JSON and Numbers (parse-community#5916)
700d2fa 
* Fix: Logger print JSON and Numbers

* fix test
This was referenced Mar 12, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplewis @davimacedo